[MIG][17.0] l10n_vn: migrate to 17.0 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duong77476-viindoo
force-pushed
the
v17_mig_l10n_vn
branch
7 times, most recently
from
5e0d8f5
to
8432983
Compare
duong77476-viindoo
changed the title
Comment on lines
30
to
32
| for tax_group_xmlid in _account_tax_group_xmlid: | ||
| new_xmlid = f"account.{company_id}_" + tax_group_xmlid.split(".")[1] | ||
| xmlids_renames.append((tax_group_xmlid, new_xmlid)) |
There was a problem hiding this comment.
@duong77476-viindoo có 2 công ty cùng dùng COA vn thì sao nhỉ?
16.0 đang dùng chung tax group giữa các công ty, anh nghĩ lên 17 sẽ cần xử như sau:
tax group sẽ đổi xml với tiền tố công ty đầu tiên, nếu có các công ty khác nữa thì phải nhân bản lên với xmlid tương ứng
account tax cũng tương tự
There was a problem hiding this comment.
E có for company trên rồi mà anh, 2 công ty Vn thì 1 cty id là 2 1 cty với id là 3 thì vẫn đúng mà ta
There was a problem hiding this comment.
@duong77476-viindoo em đang dùng rename xml, thì chỉ có 1xml mà em renamed thành 2 cái thì đâu có đúng đâu?
trừ khi rename không có thì tạo mới
duong77476-viindoo
force-pushed
the
v17_mig_l10n_vn
branch
from
8432983
to
99bcd68
Compare
openupgrade_scripts/scripts/l10n_vn/17.0.2.0.3/pre-migration.py
Outdated
Show resolved
Hide resolved
royle-vietnam
force-pushed
the
v17_mig_l10n_vn
branch
from
65ca3f5
to
98f6d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend #652
https://viindoo.com/web#id=90952&cids=1&menu_id=289&action=409&active_id=475&model=project.task&view_type=form